{"items": [{"author": "Todd", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979509313362", "anchor": "fb-979509313362", "service": "fb", "text": "I'd certainly continue.
I don't understand your criticism of #44. It seems perfectly meaningful to me, and if we hadn't carved an exception around it and vetoing, we could have blocked the PR that gave David the win.
I'd be in favor of attempting to continue with our current rule set, with bug fixes.", "timestamp": "1548777618"}, {"author": "Jeff Kaufman", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979509313362&reply_comment_id=979516523912", "anchor": "fb-979509313362_979516523912", "service": "fb", "text": "→ Todd the problem with #44 is old PRs can be revived at any time and used to represent entirely new ideas", "timestamp": "1548780674"}, {"author": "Todd", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979509313362&reply_comment_id=979521843252", "anchor": "fb-979509313362_979521843252", "service": "fb", "text": "→ We could mostly account for that by adding a condition about closing & re-opening PRs. It should be unusual for a PR to sit open for a long time without being mergeable, then become mergeable after being modified, barring an exception like point transfers that makes the whole thing moot anyway.", "timestamp": "1548784228"}, {"author": "Jeff Kaufman", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979509313362&reply_comment_id=979525121682", "anchor": "fb-979509313362_979525121682", "service": "fb", "text": "→ Todd Mostly I think this gives a false sense of security. I could open an unobjectionable PR, acquire some reviews but not enough to get it merged, and then after 24hr replace it with an objectionable one and ram it through.", "timestamp": "1548785155"}, {"author": "Todd", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979509313362&reply_comment_id=979532606682", "anchor": "fb-979509313362_979532606682", "service": "fb", "text": "→ I suppose we could change it to 24 hours from latest changes, but that would have more side effects", "timestamp": "1548789395"}, {"author": "Pavel", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979509313362&reply_comment_id=979554862082", "anchor": "fb-979509313362_979554862082", "service": "fb", "text": "→ I like #44; other people have expressed concerns about the possibility of PRs going through without them having had a chance to look at them. I'd say that we should add code that considers a PR's \"open\" date to also include any close-and-reopen shenanigans, which reset the clock.", "timestamp": "1548799625"}, {"author": "David Chudzicki", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979509313362&reply_comment_id=979554951902", "anchor": "fb-979509313362_979554951902", "service": "fb", "text": "→ Isn't it the last modified date that matters? Unless you're going to prevent people from leaving around open PRs. (Since an old open PR can be repurposed for anything.)", "timestamp": "1548799713"}, {"author": "Pavel", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979554887032", "anchor": "fb-979554887032", "service": "fb", "text": "I'd definitely play again. I'll comment more in the repo.", "timestamp": "1548799645"}, {"author": "Chelsea", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979595700242", "anchor": "fb-979595700242", "service": "fb", "text": "How long do these games last and how synchronously do the players need to pay attention to each one?", "timestamp": "1548818798"}, {"author": "Jeff Kaufman", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979595700242&reply_comment_id=979598220192", "anchor": "fb-979595700242_979598220192", "service": "fb", "text": "→ We've played once now, it took three weeks for someone to win, and generally people checked in once a day to review PRs.", "timestamp": "1548820670"}, {"author": "Jeff Kaufman", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979595700242&reply_comment_id=979598310012", "anchor": "fb-979595700242_979598310012", "service": "fb", "text": "→ A lot of this went slowly because we were building infrastructure as we went. I think if we decide to restart it we'll be able to go faster this time.
If you want to play that would be a good reason to restart!", "timestamp": "1548820715"}, {"author": "Chelsea", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979595700242&reply_comment_id=979608484622", "anchor": "fb-979595700242_979608484622", "service": "fb", "text": "→ I'd be pretty interested :)", "timestamp": "1548826766"}, {"author": "Jeff Kaufman", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979747725582", "anchor": "fb-979747725582", "service": "fb", "text": "Posted a call for new players: https://github.com/jeffkaufman/nomic/issues/85", "timestamp": "1548870521"}, {"author": "Jeff Kaufman", "source_link": "https://www.facebook.com/jefftk/posts/979507087822?comment_id=979758873242", "anchor": "fb-979758873242", "service": "fb", "text": "The game is now open again, if anyone wants to join. Make a PR like https://github.com/jeffkaufman/nomic/pull/86", "timestamp": "1548876697"}]}